Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up repair test #3931

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Speed up repair test #3931

merged 3 commits into from
Aug 6, 2024

Conversation

Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski commented Jul 16, 2024

Helps with #3929, but it is not a fix for that.

@Michal-Leszczynski
Copy link
Collaborator Author

@karol-kokoszka take a look at https://github.com/scylladb/scylla-manager/pull/3931/checks - I temporarily changed CI to always run repair pkg tests instead of the actual pkg tests, so we have 5 runs per test config (even more when if we don't care for IP_FAMILY and RAFT_SCHEMA).

We have a few categories:

  • 6.0-tablets, latest-enterprise-tablets ~ 9min
  • 2024.1 ~ 17min
  • latest-enterprise, 6.0 ~ 12min
  • 2023.1 ~ 22min

So it looks like the repair is becoming faster with newer versions and it works best with tablets (although tablet repair speed is heavily influenced by the initial tablet count, so it's not that easy to say).

What's also important, there are no ~1h test runs, so I think that this PR indeed fixes #3929.

Copy link
Collaborator

@karol-kokoszka karol-kokoszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Michal-Leszczynski Michal-Leszczynski merged commit 4cda52e into master Aug 6, 2024
51 checks passed
@Michal-Leszczynski Michal-Leszczynski deleted the ml/fix-3929 branch August 6, 2024 19:37
@karol-kokoszka karol-kokoszka mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants